This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Custom query params are not stored in a separate object #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They will be directly stored in the url just like other known query params. This also makes extra checking for other unknown query params not needed. They will also be added to state as custom query params.
roonyh
force-pushed
the
custom-query-params-directly-in-url
branch
from
1aaee5f
to
8fdf22f
Compare
Custom params are spread before core params.
ndelangen
pushed a commit
that referenced
this pull request
Apr 2, 2017
Test regex for the whole path instead of just the filename
ndelangen
pushed a commit
that referenced
this pull request
Apr 10, 2017
Make a description optional
ndelangen
pushed a commit
that referenced
this pull request
Apr 10, 2017
Fix typo - Button should be button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They will be directly stored in the url just like other known query params. This also makes extra checking for other unknown query params not needed. They will also be added to state as custom query params.