Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic-auth configuration for Kafka Connect #331

Closed
NiyiOdumosu opened this issue Sep 16, 2021 · 4 comments · Fixed by #339
Closed

Add basic-auth configuration for Kafka Connect #331

NiyiOdumosu opened this issue Sep 16, 2021 · 4 comments · Fixed by #339
Labels
enhancement New feature or request

Comments

@NiyiOdumosu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, Julie-Ops does not allow customers to authenticate to Kafka Connect with basic authentication (i.e. connectors.basic.auth=username:password)

Describe the solution you'd like
I would like the KafkaConnect class to support basic auth connection to the Kafka Connect cluster so that customers can deploy connectors with this authentication mechanism.

Describe alternatives you've considered
The other alternatives for container orchestration systems (such as Kubernetes) require a Network Policy for the connect pod that limits traffic to the other Kafka components because they cannot use basic-auth to establish a secure connection with the connect cluster.

Additional context
Add any other context or screenshots about the feature request here.

@NiyiOdumosu NiyiOdumosu added the enhancement New feature or request label Sep 16, 2021
@purbon
Copy link
Collaborator

purbon commented Sep 26, 2021

Hi @NiyiOdumosu thanks for your proposal here. I think this would be a good addition. However for now I still see a way to get that you aim here.

You would normally define the URL for the connect cluster something like this:

platform.servers.connect.0=connect:http://example.com:18083

however, when requiring basic auth, you might like to do it something like this:

platform.servers.connect.0=connect:http://username:password@example.com:18083

I know this is a workaround, but would certainly allow you to move forward with any basic auth requirement.

@purbon purbon changed the title Add basic-auth support for Kafka Connect Add basic-auth configuration for Kafka Connect Sep 26, 2021
@NiyiOdumosu
Copy link
Contributor Author

Thanks Pere! I will let our customer know this.

@purbon
Copy link
Collaborator

purbon commented Sep 30, 2021

It looks like java11 http client does not pass URL basic auth parameters, one need to pass them directly. I just merged #339 and released under v3.0.2 ... this is fixing an basic auth problem with connect.

@NiyiOdumosu
Copy link
Contributor Author

@purbon this is perfect! Thanks so much for finding the time to add this feature. Our clients will be extremely happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants