Updated Kaia changes #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-kaia
requested review from
JayChoi1736,
blukat29 and
ian0371
and removed request for
JayChoi1736 and
blukat29
JayChoi1736
reviewed
Jun 25, 2024
JayChoi1736
approved these changes
Jun 25, 2024
blukat29
approved these changes
Jun 25, 2024
ian0371
reviewed
Jun 25, 2024
| @@ -3,5 +3,5 @@ if [ "$1" = "rpc" ]; then | |||
| elif [ "$1" = "ws" ]; then | |||
| cn/bin/kcn attach ws://localhost:8552 | |||
| else | |||
| cn/bin/kcn attach cn/data/klay.ipc | |||
| cn/bin/kcn attach cn/data/kaia.ipc | |||
There was a problem hiding this comment.
are we changing this in v1.0.1? @blukat29
There was a problem hiding this comment.
No we don't because of operational risks.
There was a problem hiding this comment.
Please leave cn/data/klay as-is @praveen-klaytn .
There was a problem hiding this comment.
Reverted to cn/data/klay.ipc and updated PR
|
Cancelling this and creating a new PR as the private repo forks has some issues to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.