Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enki: the --local flag is missing #2212

Closed
Tracked by #1792
mauromorales opened this issue Feb 5, 2024 · 2 comments · Fixed by kairos-io/kairos-docs#200
Closed
Tracked by #1792

enki: the --local flag is missing #2212

mauromorales opened this issue Feb 5, 2024 · 2 comments · Fixed by kairos-io/kairos-docs#200
Assignees
Labels
bug Something isn't working regression

Comments

@mauromorales
Copy link
Member

https://github.com/kairos-io/osbuilder/blob/52475cf06990c01dedaae883a554257ff3155fd2/tools-image/build-arm-image.sh#L105

documentation should also be updated (check for more instances)

https://github.com/kairos-io/kairos-docs/blob/main/content/en/docs/Installation/automated.md?plain=1#L141

@mauromorales mauromorales added the bug Something isn't working label Feb 5, 2024
@jimmykarily jimmykarily moved this to In Progress 🏃 in 🧙Issue tracking board Feb 6, 2024
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board Feb 6, 2024
@jimmykarily jimmykarily added the documentation Improvements or additions to documentation label Feb 6, 2024
@mudler mudler changed the title osbuilder tools offers the --local flag but it doesn't do anything enki: the --local flag is missing May 3, 2024
@mudler mudler added regression and removed documentation Improvements or additions to documentation labels May 3, 2024
@mudler
Copy link
Member

mudler commented May 3, 2024

this looks a regression, such as enki now can't pull images from the local docker daemon anymore

@mudler mudler mentioned this issue May 3, 2024
33 tasks
@jimmykarily jimmykarily moved this to In Progress 🏃 in 🧙Issue tracking board May 13, 2024
@jimmykarily jimmykarily moved this from In Progress 🏃 to Todo 🖊 in 🧙Issue tracking board May 13, 2024
@mauromorales mauromorales self-assigned this May 22, 2024
@mauromorales mauromorales moved this from Todo 🖊 to In Progress 🏃 in 🧙Issue tracking board May 22, 2024
@mauromorales
Copy link
Member Author

As far as I can tell, enki can use the local registry either directly e.g.

sudo ./enki build-iso kairos:ubuntu -n out -o build --config-dir ./
[sudo] password for mauro: 
INFO[2024-05-22T14:26:28+02:00] Starting enki version v0.0.1                 
INFO[2024-05-22T14:26:28+02:00] Preparing squashfs root...                   
INFO[2024-05-22T14:26:28+02:00] Copying kairos:rpi source to /tmp/enki-iso791749851/rootfs 
INFO[2024-05-22T14:26:39+02:00] Finished copying kairos:rpi into /tmp/enki-iso791749851/rootfs 
INFO[2024-05-22T14:26:39+02:00] Preparing ISO image root tree...

Or via osbuilder

IMAGE=kairos:rpi
docker pull $IMAGE
# Validate the configuration file
kairosctl validate cloud-config.yaml
# Customize it
mkdir -p build
docker run -v $PWD:/HERE \
 -v /var/run/docker.sock:/var/run/docker.sock \
 --privileged -i --rm \
 --entrypoint=/build-arm-image.sh quay.io/kairos/osbuilder-tools:v0.200.9 \
 --use-lvm \
 --model rpi4 \
 --state-partition-size 6200 \
 --recovery-partition-size 4200 \
 --size 15200 \
 --images-size 2000 \
 --local \
 --config /HERE/cloud-config.yaml \
 --docker-image $IMAGE /HERE/build/out.img

For what I understand, --local was a flag from elemental-cli

https://github.com/kairos-io/elemental-cli/blob/6b92df9b6b1af42bb7d7f6ae97961d4da930a715/cmd/flags.go#L66

and it was removed since we switched to using the kairos-agent in

kairos-io/osbuilder@92193ab

hence the original comment/title that it just needs to be removed from osbuilder. In addition, I checked and the --disable-lvm and --use-lvm flags were also removed in

kairos-io/osbuilder@c813e54

All the rest of the flags seem to be correct

mauromorales added a commit to kairos-io/kairos-docs that referenced this issue May 22, 2024
fixes kairos-io/kairos#2212

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@github-project-automation github-project-automation bot moved this from In Progress 🏃 to Done ✅ in 🧙Issue tracking board May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants