Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose intl-messageformat option ignoreTag #121

Merged

Conversation

superafroman
Copy link
Contributor

With the latest release and move to the latest intl-messageformat messages that include variables and HTML tags have started to throw errors.

This PR exposes the new option ignoreTag and defaults it to true for backwards compatibility.

See issue #120

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test

@superafroman
Copy link
Contributor Author

Build seems to be failing because it's ignoring the .eslintrc config. Locally linting passes with no errors.

@kaisermann
Copy link
Owner

kaisermann commented Feb 11, 2021

Hey @superafroman 👋 Thanks! Nice 🎉 Released in v3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants