Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): add version to the daemons #598

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(all): add version to the daemons #598

merged 1 commit into from
Oct 6, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Oct 6, 2023

What this PR does

This PR adds the version to the daemons. It infers the correct version from the git's latest tag.

This PR adds the version to the daemons. It infers the correct version from the git's latest tag.
@ijsong ijsong requested a review from hungryjang as a code owner October 6, 2023 07:26
@ijsong
Copy link
Member Author

ijsong commented Oct 6, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a4117e) 61.25% compared to head (ab345de) 61.21%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   61.25%   61.21%   -0.04%     
==========================================
  Files         144      144              
  Lines       19185    19185              
==========================================
- Hits        11752    11745       -7     
- Misses       6845     6851       +6     
- Partials      588      589       +1     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong merged commit a430609 into main Oct 6, 2023
@ijsong ijsong deleted the add_version branch October 6, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants