From c11619b1027d81dbf201a2e585a09309ee62fa4e Mon Sep 17 00:00:00 2001 From: Kemal Akkoyun Date: Thu, 5 Oct 2023 15:42:48 +0200 Subject: [PATCH] Update dependecies Signed-off-by: Kemal Akkoyun --- Cargo.toml | 12 +++++++----- README.md | 4 ++-- src/py_perf.rs | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 23dae87..e816816 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -31,17 +31,19 @@ nix = "0.26" num_cpus = "1.16" perf-event-open-sys = "4.0" plain = "0.2.3" -# pprof = { path = "../../Sandbox/Profiling/pprof-rs", features = [ -pprof = { git = "ssh://git@github.com/kakkoyun/py-spy.git", features = [ + +# TODO(kakkoyun): Send a patch to upstream. +pprof = { git = "ssh://git@github.com/kakkoyun/pprof-rs.git", features = [ + # pprof = { path = "../../Sandbox/Profiling/pprof-rs", features = [ "flamegraph", "inferno", "protobuf", - "protobuf-codec", + "protobuf-codec" ] } proc-maps = "0.3" -# py-spy = { path = "../../Sandbox/Profilers/py-spy" } # TODO(kakkoyun): Send a patch to upstream. py-spy = { git = "ssh://git@github.com/kakkoyun/py-spy.git" } +# py-spy = { path = "../../Sandbox/Profilers/py-spy" } remoteprocess = { version = "0.4.12", features = ["unwind"] } serde = { version = "1.0", features = ["derive"] } serde_json = "1.0" @@ -50,7 +52,7 @@ thiserror = "1.0" time = { version = "0.3.24", features = [ "formatting", "local-offset", - "macros", + "macros" ] } [build-dependencies] diff --git a/README.md b/README.md index a559b43..dc8b2b6 100644 --- a/README.md +++ b/README.md @@ -88,7 +88,7 @@ Kernel-space code (eBPF profiler): GNU General Public License, version 2 - TODO(kakkoyun): Add sections from parca-agent! - TODO(kakkoyun): Add reference to bcc, bcc/granulate and linux/tool examples from facebook. -## Features: +## Features - Supports profiling Python processes running in Docker containers. Tested using official Python Docker images (`python:X.Y`). @@ -96,7 +96,7 @@ Kernel-space code (eBPF profiler): GNU General Public License, version 2 - Supports Python compiled in both PIE and non-PIE configurations. - Supports Python running standalone and as a library (linked with `libpythonX.Y`). -## Limitations: +## Limitations - Architecture: x86_64. - Linux kernel version: oldest version tested is 4.14. Versions 4.11-4.14 may work. Required for diff --git a/src/py_perf.rs b/src/py_perf.rs index 83c62d2..7ca6f12 100644 --- a/src/py_perf.rs +++ b/src/py_perf.rs @@ -13,7 +13,7 @@ use libbpf_rs::skel::{OpenSkel, SkelBuilder}; use libbpf_rs::{MapFlags, PerfBufferBuilder, ProgramType}; use anyhow::{bail, Context, Result}; -use crossbeam::channel::{bounded, select, tick, unbounded, Receiver, RecvError}; +use crossbeam::channel::{bounded, select, tick, unbounded, Receiver}; use plain::Plain; use py_spy::version::Version; use serde_yaml;