[nat] Allowing either CLI option or /var/run/secrets/kubernetes.io/serviceaccount/namespace detection #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Builds off of hyperledger#6088 and avoids the need for the new experimental namespace option.
If running within Kubernetes, Services create Endpoints for Pods in the same Namespace. So it is unnecessary to assume a Besu Pod will need to detect a LoadBalancer Service in a separate Namespace from itself (which is why it's great we're avoiding need access to all Namespaces bc that violates least privileges).
However, the Kubernetes docs mention:
It's debatable if LoadBalancer Services even work in such a scenario, and feels simpler to just simply state that is unsupported and therefore Besu only looks for Services in its same Namespace.
As a result, we can rely on this file that should always be present since ServiceAccount is always mounted to a Pod. And we fallback to the default if not.
Fixed Issue(s)
Addresses concerns from hyperledger#6088 (comment).