Handle out of bound history entries + fix last known entry #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloeckner
added a commit
to akloeckner/mini-graph-card
that referenced
this pull request
Dec 3, 2022
The fix from kalkih#251 introduced a logic that 1. allocated all "too-old" coords to the first group coords[0] 2. deleted all but one entries from that first group. This caused aggregators to stop calculating proper results for that first group. The proposed new logic drops out-of-bounds entries already in the reducer. This allows the first group to have multiple entries. Aggregate functions should now work again.
akloeckner
added a commit
to akloeckner/mini-graph-card
that referenced
this pull request
Apr 22, 2023
The fix from kalkih#251 introduced a logic that 1. allocated all "too-old" coords to the first group coords[0] 2. deleted all but one entries from that first group. This caused aggregators to stop calculating proper results for that first group. The proposed new logic drops out-of-bounds entries already in the reducer. This allows the first group to have multiple entries. Aggregate functions should now work again.
akloeckner
added a commit
that referenced
this pull request
Apr 22, 2023
The fix from #251 introduced a logic that 1. allocated all "too-old" coords to the first group coords[0] 2. deleted all but one entries from that first group. This caused aggregators to stop calculating proper results for that first group. The new logic drops out-of-bounds entries already in the reducer. This allows the first group to have multiple entries. Aggregate functions now work again. Also clean up reducer code with no funtional change.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2023
# [0.12.0-dev.1](v0.11.0...v0.12.0-dev.1) (2023-04-22) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2024
# [0.12.0](v0.11.0...v0.12.0) (2024-01-27) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * cards would always assume icon_image was set ([#957](#957)) ([f376732](f376732)) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * retain the last out-of-bounds state ([#961](#961)) ([8ebe173](8ebe173)), closes [#881](#881) [#960](#960) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * Add support of attribute tree when available ([#996](#996)) ([9c1c31e](9c1c31e)) * pull two years worth of changes into release channel ([f5fb98d](f5fb98d)), closes [#1059](#1059) * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries that were out of bound by more than x amount of time would be pushed into the timeline again because of the use of Math.abs() when calculating the position in the timeline.
This change will make sure these entries are handled as out of bound.
This will also make sure we calculate the "last known entry" based on the actual "most recent last known entry" and not by a calculation on the aggregation of all out of bound entries.