fix: add first datapoint tooltip for line graph #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beware of #878. When trying to fix that, too, now, I realized they're linked somehow. Tooltip dates are off a day, now. I'll investigate and amend... |
akloeckner
force-pushed
the
fix/first-point
branch
from
6f666b3
to
886d668
Compare
|
Done. This might have fixed #878, too. Will need to check later... |
introduce a completely separated code block for smoothing compress code in that course
akloeckner
force-pushed
the
fix/first-point
branch
from
886d668
to
2c945e4
Compare
|
The smoothed graphs required some of the logic I had removed in my first commit. So, now cleaned up the change, such that the (somewhat involved) logic for smoothing is in a separate code block. This still fixes also #878. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2023
# [0.12.0-dev.1](v0.11.0...v0.12.0-dev.1) (2023-04-22) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
|
🎉 This PR is included in version 0.12.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 27, 2024
# [0.12.0](v0.11.0...v0.12.0) (2024-01-27) ### Bug Fixes * add first datapoint tooltip for line graph ([#882](#882)) ([7576fe6](7576fe6)) * allow zero tooltip ([057a395](057a395)), closes [#805](#805) * cards would always assume icon_image was set ([#957](#957)) ([f376732](f376732)) * drop out-of-bound coords in reducer ([#881](#881)) ([527f005](527f005)), closes [#251](#251) * retain the last out-of-bounds state ([#961](#961)) ([8ebe173](8ebe173)), closes [#881](#881) [#960](#960) * **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [#872](#872) * **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f)) * **workflows:** remove invalid description field ([e755e24](e755e24)) ### Features * Add support of attribute tree when available ([#996](#996)) ([9c1c31e](9c1c31e)) * pull two years worth of changes into release channel ([f5fb98d](f5fb98d)), closes [#1059](#1059) * **option:** override icon with an image URL ([#789](#789)) ([2860a09](2860a09))
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already the first commit 7e15867 introducing tooltips did not render the first data point as tooltip-able. While there certainly was a reason for it, I cannot figure it out. Additionally, there is no such logic for bar tooltips (
getBars) nor in the actual line graph (getLine). So, I propose to include the first point in the tooltips.Fixes #879, #878