Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkplay integration moving into core #866

Open
MahrWe opened this issue Nov 2, 2024 · 10 comments
Open

Linkplay integration moving into core #866

MahrWe opened this issue Nov 2, 2024 · 10 comments

Comments

@MahrWe
Copy link

MahrWe commented Nov 2, 2024

The correct join and unjoin, for the new core-linkplay integration, should be from media_player platform.

linkplay.join should be changed to media_player.join to work with the new integration.

return this.callService(e, 'join', options, platform);

@probert94
Copy link

I am getting error Action linkplay.join not found now in 2024.11

@ccristal
Copy link

Please fix this. As of 2024.11.2, the Linkplay integration in Core is fully functional, but link/unlink don't work in mini-media-player for this platform.

@DaveCBr
Copy link

DaveCBr commented Nov 17, 2024

When Linkplay became part of the Core, the developer of Linkplay did not include this along with several other features. It must be added to Linkplay prior to it working here.

@probert94
Copy link

@DaveCBr the Linkplay-Integration seems to support join / unjoin now. The problem is, that the mini-media-play is using command linkplay.join for linkplay devices instead of media_player.join.
I don't think the new linkplay integration will ever support linkplay.join as that command was only needed because the standard media_player.join was added later.

@mk13139
Copy link

mk13139 commented Nov 21, 2024

The Linkplay integration now supports the standard media_player actions, including media_player.join/media_player.unjoin.
linkplay.join should be changed to media_player.join
linkplay.unjoin should be changed to media_player.unjoin

@DaveCBr
Copy link

DaveCBr commented Dec 1, 2024

I see that the code was changed for join/unjoin however still getting errors thrown from link play.

"Failed to perform the action media_player/join. Entity media_player.deck_dlna does not support this service"

This is probably a format issue of the command. It should be media_player.join not /join

@MahrWe
Copy link
Author

MahrWe commented Dec 1, 2024

@DaveCBr which branch are you using? In my branch join works. The problem is the way the group members are determined. Joined devices are not correctly displayed in the mini-media-player.

@DaveCBr
Copy link

DaveCBr commented Dec 2, 2024

I am using the base branch/ version that is released. What version should I load as a test?

@mk13139
Copy link

mk13139 commented Dec 12, 2024

Any update on this? @MahrWe @DaveCBr

@MahrWe
Copy link
Author

MahrWe commented Dec 12, 2024

I created an issue on the linkplay integration in ha-core. To fix the group_members property, maybe someone can help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants