fix(FEC-8940): cannot configure plugin by array (#222)

iterating on array
kaltura · Jun 11, 2019 · 0237207 · 0237207
1 parent f7fa3ac
commit 0237207
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/common/plugins/plugins-config.js b/src/common/plugins/plugins-config.js
@@ -24,6 +24,8 @@ const removeUnevaluatedExpression = (obj = {}): Object =>
   Object.entries(obj).reduce((product, [key, value]): Object => {
     if (typeof value !== 'function' && Utils.Object.isObject(value)) {
       product[key] = removeUnevaluatedExpression(value);
+    } else if (Array.isArray(value)) {
+      product[key] = value.filter(index => isValueEvaluated(index));
     } else if (isValueEvaluated(value)) {
       product[key] = value;
     }

diff --git a/test/src/common/plugins/plugins-config.spec.js b/test/src/common/plugins/plugins-config.spec.js
@@ -10,7 +10,8 @@ describe('evaluatePluginsConfig', function() {
   const pluginsConfig = {
     kava: {
       myHandler: function() {},
-      myUnevaluatedConfig: '{{abc}}'
+      myUnevaluatedConfig: '{{abc}}',
+      myArray: [1, 'value', 0, true, '{{value}}', false]
     }
   };
 
@@ -30,4 +31,9 @@ describe('evaluatePluginsConfig', function() {
     evaluatePluginsConfig(pluginsConfig, playerConfig);
     pluginsConfig.kava.should.not.have.property('myUnevaluatedConfig');
   });
+
+  it('should remove unevaluated plugins config from array', function() {
+    evaluatePluginsConfig(pluginsConfig, playerConfig);
+    pluginsConfig.kava.myArray.should.deep.equal([1, 'value', 0, true, false]);
+  });
 });