fix(FEC-8719): volume is not in sync when switching between sender-re…

…ceiver (#189) * FEC-8595 * Update player-snapshot.js * fix build * FEC-8719
kaltura · Dec 16, 2018 · 222d214 · 222d214
1 parent 8825fae
commit 222d214
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/src/common/cast/player-snapshot.js b/src/common/cast/player-snapshot.js
@@ -36,8 +36,6 @@ class PlayerSnapshot {
       playback: {
         startTime: getStartTime(player),
         autoplay: player.currentTime === 0 ? true : !player.paused,
-        volume: player.volume,
-        muted: player.muted,
         audioLanguage: getLanguage(TrackType.AUDIO, player),
         textLanguage: getLanguage(TrackType.TEXT, player)
       }

diff --git a/src/common/cast/remote-control.js b/src/common/cast/remote-control.js
@@ -137,7 +137,7 @@ function onRemoteDeviceDisconnected(payload: RemoteDisconnectedPayload): void {
       if (mediaInfo) {
         this.loadMedia(mediaInfo).then(() => {
           this._eventManager.listenOnce(this, this.Event.Core.FIRST_PLAYING, () => {
-            setInitialAttributes.call(this, snapshot);
+            this.textStyle = snapshot.textStyle;
             configurePlayback.call(this, originPlaybackConfig);
             setInitialTracks.call(this, snapshot);
           });
@@ -217,12 +217,6 @@ function configurePlayback(playbackConfig: Object): void {
   });
 }
 
-function setInitialAttributes(snapshot: PlayerSnapshot): void {
-  this.textStyle = snapshot.textStyle;
-  this.volume = snapshot.config.playback.volume;
-  this.muted = snapshot.config.playback.muted;
-}
-
 function setInitialTracks(playbackConfig: Object): void {
   if (playbackConfig.audioLanguage) {
     const audioTrack = this.getTracks(TrackType.AUDIO).find(t => t.language === playbackConfig.audioLanguage);

diff --git a/src/common/storage/storage-manager.js b/src/common/storage/storage-manager.js
@@ -33,13 +33,19 @@ export default class StorageManager {
   static attach(player: Player): void {
     StorageManager._logger.debug('Attach local storage');
     player.addEventListener(player.Event.UI.USER_CLICKED_MUTE, () => {
-      StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, player.muted);
+      if (!player.isCasting()) {
+        StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, player.muted);
+      }
     });
     player.addEventListener(player.Event.UI.USER_CLICKED_UNMUTE, () => {
-      StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, player.muted);
+      if (!player.isCasting()) {
+        StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, player.muted);
+      }
     });
     player.addEventListener(player.Event.UI.USER_CHANGED_VOLUME, () => {
-      StorageWrapper.setItem(StorageManager.StorageKeys.VOLUME, player.volume);
+      if (!player.isCasting()) {
+        StorageWrapper.setItem(StorageManager.StorageKeys.VOLUME, player.volume);
+      }
     });
     player.addEventListener(player.Event.UI.USER_SELECTED_AUDIO_TRACK, event => {
       const audioTrack = event.payload.audioTrack;