fix(FEC-11062): ad layout doesn't work when IMA DAI configured (#425)

Issue: play ad now to use the active plugin with play ad now API. Solution: instead of empty implementation on ad plugins, implement it only where it's needed, and check if there's a plugin with this API available to play the ad.
kaltura · Mar 8, 2021 · 2251d5f · 2251d5f
1 parent edc1fee
commit 2251d5f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/flow-typed/interfaces/ads-plugin-controller.js b/flow-typed/interfaces/ads-plugin-controller.js
@@ -2,7 +2,7 @@
 
 declare interface IAdsPluginController {
   skipAd(): void;
-  playAdNow(adPod: KPAdPod): void;
+  playAdNow?: (adPod: KPAdPod) => void;
   onPlaybackEnded(): Promise<void>;
   +active: boolean;
   +done: boolean;

diff --git a/src/common/controllers/ads-controller.js b/src/common/controllers/ads-controller.js
@@ -280,11 +280,12 @@ class AdsController extends FakeEventTarget implements IAdsController {
   }
 
   _playAdBreak(adBreak: RunTimeAdBreakObject): void {
-    const adController = this._adsPluginControllers.find(controller => !this._isBumper(controller));
+    const adController = this._adsPluginControllers.find(controller => typeof controller.playAdNow === 'function');
     if (adController) {
       adBreak.played = true;
       this._adIsLoading = true;
       AdsController._logger.debug(`Playing ad break positioned in ${adBreak.position}`);
+      // $FlowFixMe
       adController.playAdNow(adBreak.ads);
     } else {
       AdsController._logger.warn('No ads plugin registered');