fix(FEC-8773): local storage mute state is not updated when user drag…

… volume bar (#190) Manipulate the muted value saved in the local storage in case user changed volume.
kaltura · Dec 19, 2018 · 28d098f · 28d098f
1 parent 792fed4
commit 28d098f
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 1 deletion.
diff --git a/src/common/storage/storage-manager.js b/src/common/storage/storage-manager.js
@@ -44,6 +44,11 @@ export default class StorageManager {
     });
     player.addEventListener(player.Event.UI.USER_CHANGED_VOLUME, () => {
       if (!player.isCasting()) {
+        if (player.volume > 0) {
+          StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, false);
+        } else {
+          StorageWrapper.setItem(StorageManager.StorageKeys.MUTED, true);
+        }
         StorageWrapper.setItem(StorageManager.StorageKeys.VOLUME, player.volume);
       }
     });

diff --git a/test/src/common/storage/storage-manager.spec.js b/test/src/common/storage/storage-manager.spec.js
@@ -1,18 +1,40 @@
 import StorageManager from '../../../../src/common/storage/storage-manager';
 import StorageWrapper from '../../../../src/common/storage/storage-wrapper';
+import * as TestUtils from '../../utils/test-utils';
+import {setup} from '../../../../src';
+import {FakeEvent} from '@playkit-js/playkit-js';
+
+const targetId = 'player-placeholder_storage-manager.spec';
 
 describe('StorageManager', function() {
-  let sandbox;
+  let config, player, sandbox;
+  const partnerId = 1091;
+  const entryId = '0_wifqaipd';
+
+  before(function() {
+    TestUtils.createElement('DIV', targetId);
+  });
 
   beforeEach(function() {
     sandbox = sinon.sandbox.create();
+    config = {
+      targetId: targetId,
+      provider: {
+        partnerId: partnerId
+      }
+    };
   });
 
   afterEach(function() {
     sandbox.restore();
+    TestUtils.removeVideoElementsFromTestPage();
     window.localStorage.clear();
   });
 
+  after(function() {
+    TestUtils.removeElement(targetId);
+  });
+
   it('should return it has no storage', function() {
     sandbox.stub(StorageWrapper, '_testForLocalStorage').callsFake(() => {
       StorageWrapper._isLocalStorageAvailable = true;
@@ -69,4 +91,24 @@ describe('StorageManager', function() {
       }
     });
   });
+
+  it('should set muted to true/false depends on changed volume', function() {
+    sandbox.stub(StorageWrapper, '_testForLocalStorage').callsFake(() => {
+      StorageWrapper._isLocalStorageAvailable = true;
+    });
+    player = setup(config);
+    player.loadMedia({entryId: entryId}).then(() => {
+      player.muted = true;
+      player.dispatchEvent(new FakeEvent(player.Event.UI.USER_CLICKED_MUTE));
+      StorageManager.getStorageConfig().playback.muted.should.be.true;
+      player.volume = 0.5;
+      player.dispatchEvent(new FakeEvent(player.Event.UI.USER_CHANGED_VOLUME));
+      StorageManager.getStorageConfig().playback.muted.should.be.false;
+      StorageManager.getStorageConfig().playback.volume.should.equals(0.5);
+      player.volume = 0;
+      player.dispatchEvent(new FakeEvent(player.Event.UI.USER_CHANGED_VOLUME));
+      StorageManager.getStorageConfig().playback.muted.should.be.true;
+      StorageManager.getStorageConfig().playback.volume.should.equals(0);
+    });
+  });
 });