Skip to content

Commit

Permalink
feat(poster): decorate poster call with player dimensions (#15)
Browse files Browse the repository at this point in the history
* feat(poster): decorate poster call with player dimensions

* Fix CSS for player display

* CR fixes

* chore: update test page

* chore: update dist

* Update index.html
  • Loading branch information
OrenMe authored Aug 8, 2017
1 parent 2393215 commit 2a5b853
Show file tree
Hide file tree
Showing 8 changed files with 2,597 additions and 2,142 deletions.
4,697 changes: 2,570 additions & 2,127 deletions dist/kaltura-player.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/kaltura-player.js.map

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/kaltura-player.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/kaltura-player.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/assets/style.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.kaltura-player-container {
width: 100%;
height: 100%;
position: relative;
position: absolute;
outline: none;
-webkit-touch-callout: none;
-webkit-user-select: none;
Expand Down
7 changes: 1 addition & 6 deletions src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,13 @@
plugins: {
kanalytics: {
beUrl: "http://qa-apache-testing-ubu-01.dev.kaltura.com/api_v3"
},
ima: {
adTagUrl: 'https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpreonly&cmsid=496&vid=short_onecue&correlator='
}
}
};

try {
var kalturaPlayer = KalturaPlayer.setup('player-placeholder', config);
kalturaPlayer.loadMedia('0_wifqaipd').then(function () {
kalturaPlayer.play();
});
kalturaPlayer.loadMedia('0_wifqaipd');
} catch (e) {
console.error(e.message)
}
Expand Down
5 changes: 5 additions & 0 deletions src/kaltura-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import PlaykitUI from 'playkit-js-ui'
import OvpProvider from 'playkit-js-providers/dist/ovpProvider'
import LoggerFactory from './utils/logger'
import {addKalturaParams} from './utils/kaltura-params'
import {addKalturaPoster} from './utils/setup-helpers'
import './assets/style.css'

export default class KalturaPlayer {
Expand All @@ -28,9 +29,13 @@ export default class KalturaPlayer {
return this._provider.getConfig(entryId, uiConfId)
.then((data) => {
let playerConfig = {};
const dimensions = this._player.dimensions;
addKalturaPoster(data.metadata, dimensions.width, dimensions.height);
addKalturaParams(data.sources, this._player);
Utils.Object.mergeDeep(playerConfig, this._player.config, data);
this._player.configure(playerConfig);
});
}
}


12 changes: 12 additions & 0 deletions src/utils/setup-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,22 @@ function createKalturaPlayerContainer(targetId: string): string {
return el.id;
}

/**
* Add poster with player dimensions to thumbnail API call
* @param {Object} metadata - metadata container
* @param {number} width - player width in px
* @param {number} height - player height in px
* @returns {void}
*/
function addKalturaPoster(metadata: Object, width: number, height: number): void{
metadata.poster = `${metadata.poster}/height/${height}/width/${width}`;
}

export {
extractPlayerConfig,
extractProvidersConfig,
createKalturaPlayerContainer,
addKalturaPoster,
validateTargetId,
validateProvidersConfig
};

0 comments on commit 2a5b853

Please sign in to comment.