Skip to content

Commit

Permalink
fix(FEC-9087): IMA DAI - the pre-roll Ad duration also calculated for…
Browse files Browse the repository at this point in the history
… start position - the playback started from 10th sec instead of 20th (#240)

config hls by default `autoStartLoad:false` to enable kaltura/playkit-js-ima-dai#15 to override the [`startPosition`](https://github.com/video-dev/hls.js/blob/master/docs/API.md#startposition) value.
  • Loading branch information
yairans authored Jun 10, 2019
1 parent c24c981 commit 6c4c73a
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions src/common/utils/setup-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ function getDefaultOptions(options: PartialKPOptionsObject): KPOptionsObject {
setDefaultAnalyticsPlugin(defaultOptions);
configureVrDefaultOptions(defaultOptions);
configureLGTVDefaultOptions(defaultOptions);
configureDAIDefaultOptions(defaultOptions);
configureExternalStreamRedirect(defaultOptions);
return defaultOptions;
}
Expand Down Expand Up @@ -340,6 +341,31 @@ function configureLGTVDefaultOptions(options: KPOptionsObject): void {
}
}
/**
* Sets default config option for dai plugin
* @private
* @param {KPOptionsObject} options - kaltura player options
* @returns {void}
*/
function configureDAIDefaultOptions(options: KPOptionsObject): void {
if (options.plugins && options.plugins.imadai && !options.plugins.imadai.disable) {
const autoStartLoadConfig = Utils.Object.getPropertyPath(options, 'playback.options.html5.hls.autoStartLoad');
if (typeof autoStartLoadConfig !== 'boolean') {
Utils.Object.mergeDeep(options, {
playback: {
options: {
html5: {
hls: {
autoStartLoad: false
}
}
}
}
});
}
}
}

/**
* Transform options structure from legacy structure to new structure.
* @private
Expand Down

0 comments on commit 6c4c73a

Please sign in to comment.