Skip to content

Commit

Permalink
fix(FEC-8901): duplication of ClosedCaptions on iOS on none Safari br…
Browse files Browse the repository at this point in the history
…owser (#221)

Changed the `if` condition of `checkNativeTextTracksSupport` function, to allow other browsers in iOS to set it to `true` by default.

From `isSafari()` -> to `isSafari() || isIos()`

- Tested the matter with iPad in Chrome, Safari, and FireFox.
  • Loading branch information
Shalom Meoded authored and yairans committed Feb 21, 2019
1 parent 88b80c5 commit 7dbc175
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/common/utils/setup-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ function configureDelayAdsInitialization(options: KPOptionsObject): void {
* @returns {void}
*/
function checkNativeTextTracksSupport(options: KPOptionsObject): void {
if (isSafari()) {
if (isSafari() || isIos()) {
const useNativeTextTrack = Utils.Object.getPropertyPath(options, 'playback.useNativeTextTrack');
if (typeof useNativeTextTrack !== 'boolean') {
Utils.Object.mergeDeep(options, {
Expand Down

0 comments on commit 7dbc175

Please sign in to comment.