fix(FEC-11498): Remove product version from player config (#492)

Remove product version from player config
kaltura · Sep 13, 2021 · 900ad75 · 900ad75
1 parent db18aad
commit 900ad75
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/common/utils/kaltura-params.js b/src/common/utils/kaltura-params.js
@@ -1,5 +1,6 @@
 //@flow
 import {StreamType, Utils} from '@playkit-js/playkit-js';
+import {getServerUIConf} from './setup-helpers';
 
 const PLAY_MANIFEST = 'playmanifest/';
 const PLAY_SESSION_ID = 'playSessionId=';
@@ -159,7 +160,7 @@ function addKalturaParams(player: Player, playerConfig: PartialKPOptionsObject):
   handleSessionId(player, playerConfig);
   const sources = playerConfig.sources;
   const sessionId = playerConfig.session && playerConfig.session.id;
-  const productVersion = player.config.productVersion;
+  const productVersion = getServerUIConf()?.productVersion;
   Object.values(StreamType).forEach(key => {
     // $FlowFixMe
     if (sources[key]) {

diff --git a/src/common/utils/setup-helpers.js b/src/common/utils/setup-helpers.js
@@ -312,7 +312,9 @@ function getDefaultOptions(options: PartialKPOptionsObject): KPOptionsObject {
   Utils.Object.mergeDeep(defaultOptions, options);
 
   if (!options.provider.ignoreServerConfig) {
-    defaultOptions = Utils.Object.mergeDeep({}, supportLegacyOptions(getServerUIConf()), defaultOptions);
+    const serverUIConf = Utils.Object.copyDeep(getServerUIConf());
+    delete serverUIConf.productVersion;
+    defaultOptions = Utils.Object.mergeDeep({}, supportLegacyOptions(serverUIConf), defaultOptions);
   }
 
   checkNativeHlsSupport(defaultOptions);
@@ -732,5 +734,6 @@ export {
   getDefaultOptions,
   maybeSetStreamPriority,
   hasYoutubeSource,
-  mergeProviderPluginsConfig
+  mergeProviderPluginsConfig,
+  getServerUIConf
 };
diff --git a/test/src/common/utils/kaltura-params.spec.js b/test/src/common/utils/kaltura-params.spec.js
@@ -218,8 +218,8 @@ describe('addClientTag', function () {
   it('should add client tag as first param', function () {
     let source = {url: 'a/b/c/playmanifest/source'};
     let productVersion = '7.37';
-    player.config = {session: {}, productVersion};
-    source.url = addClientTag(source.url, player.config.productVersion);
+    player.config = {session: {}};
+    source.url = addClientTag(source.url, productVersion);
     source.url.should.be.equal('a/b/c/playmanifest/source?clientTag=html5:v' + productVersion);
   });