Skip to content

Commit

Permalink
feat: player doesn't attach itself to parent (#27)
Browse files Browse the repository at this point in the history
only create instance of playkit and pass it to UI as we do today.
UI manager will attach it to DOM as part of entire UI build out.
This depends on kaltura/playkit-js#113 and future PR on playkit-js-ui SDK
  • Loading branch information
OrenMe committed Sep 17, 2017
1 parent 0f1ac3a commit b612d57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function setup(targetId: string, options: Object): KalturaPlayer {
let userProvidersConfig = extractProvidersConfig(options);
let containerId = createKalturaPlayerContainer(targetId);
checkNativeHlsSupport(userPlayerConfig);
let player = loadPlayer(containerId, userPlayerConfig);
let player = loadPlayer(userPlayerConfig);
let kalturaPlayerApi = new KalturaPlayer(player, containerId, userProvidersConfig);
let kalturaPlayer = Object.assign(player, kalturaPlayerApi);
if (StorageManager.isLocalStorageAvailable()) {
Expand Down

0 comments on commit b612d57

Please sign in to comment.