feat(FEC-10632): handle player dimensions dynamically (#373)

kaltura · Nov 23, 2020 · c0bf2e1 · c0bf2e1
1 parent 63f698d
commit c0bf2e1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/flow-typed/types/kaltura-player-options.js b/flow-typed/types/kaltura-player-options.js
@@ -12,6 +12,7 @@ declare type KPOptionsObject = {
   session?: PKSessionConfigObject,
   provider: ProviderOptionsObject,
   playlist?: KPPlaylistObject,
+  dimensions?: PKDimensionsConfig,
   ui: KPUIOptionsObject,
   cast?: {[key: string]: any},
   productVersion?: string
@@ -28,6 +29,7 @@ declare type PartialKPOptionsObject = {
   session?: PKSessionConfigObject,
   provider: ProviderOptionsObject,
   playlist?: KPPlaylistObject,
+  dimensions?: PKDimensionsConfig,
   ui?: KPUIOptionsObject,
   cast?: {[key: string]: any}
 };

diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
   },
   "dependencies": {
     "@babel/polyfill": "^7.0.0",
-    "@playkit-js/playkit-js": "0.64.3",
+    "@playkit-js/playkit-js": "0.65.0-canary.9cbf0cf",
     "@playkit-js/playkit-js-dash": "1.20.3",
     "@playkit-js/playkit-js-hls": "1.21.2",
     "@playkit-js/playkit-js-ui": "0.60.1",

diff --git a/src/kaltura-player.js b/src/kaltura-player.js
@@ -461,7 +461,11 @@ class KalturaPlayer extends FakeEventTarget {
     return this._localPlayer.src;
   }
 
-  get dimensions(): Object {
+  set dimensions(dimensions?: PKPlayerDimensions) {
+    this._localPlayer.dimensions = dimensions;
+  }
+
+  get dimensions(): PKPlayerDimensions {
     return this._localPlayer.dimensions;
   }
 

diff --git a/yarn.lock b/yarn.lock
@@ -1150,10 +1150,10 @@
     react-redux "^7.2.0"
     redux "^4.0.5"
 
-"@playkit-js/playkit-js@0.64.3":
-  version "0.64.3"
-  resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js/-/playkit-js-0.64.3.tgz#00cdae6eabb770df0db4cc7c311fdce13b09130f"
-  integrity sha512-041teVmxIRlpoXq6QZ0XcO1fVzFIR3B0NS2HxX4mJldlkvk/nGwBRnWvLm7ZdRr1Y4a7TgOYzEYXKhYNtg8nwQ==
+"@playkit-js/playkit-js@0.65.0-canary.9cbf0cf":
+  version "0.65.0-canary.9cbf0cf"
+  resolved "https://registry.yarnpkg.com/@playkit-js/playkit-js/-/playkit-js-0.65.0-canary.9cbf0cf.tgz#949d21e195d46c004ec06e73c7ee5b0b0a2e8392"
+  integrity sha512-40wyqijY9dKZshimpn+usL5iVus7P40kNJpyZBwLEn3agjX+wtR85AAIGIRX+9SOcUWypDjPVlAYpF4OvYDGFg==
   dependencies:
     js-logger "^1.6.0"
     ua-parser-js "^0.7.21"