fix(FEC-8637): not possible to pass a function in a plugin configurat…

…ion (#163)
kaltura · Nov 4, 2018 · cb2c5af · cb2c5af
1 parent efbe961
commit cb2c5af
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/common/plugins/plugins-config.js b/src/common/plugins/plugins-config.js
@@ -11,7 +11,8 @@ import {Utils} from 'playkit-js';
  * @returns {boolean} - value is evaluated
  */
 const isValueEvaluated = (value: any): boolean =>
-  (typeof value === 'number' || typeof value === 'string' || typeof value === 'boolean') && !templateRegex.test(value.toString());
+  (typeof value === 'number' || typeof value === 'function' || typeof value === 'string' || typeof value === 'boolean') &&
+  !templateRegex.test(value.toString());
 
 /**
  * remove unevaluated expressions form object
@@ -21,7 +22,7 @@ const isValueEvaluated = (value: any): boolean =>
  */
 const removeUnevaluatedExpression = (obj = {}): Object =>
   Object.entries(obj).reduce((product, [key, value]): Object => {
-    if (Utils.Object.isObject(value)) {
+    if (typeof value !== 'function' && Utils.Object.isObject(value)) {
       product[key] = removeUnevaluatedExpression(value);
     } else if (isValueEvaluated(value)) {
       product[key] = value;

diff --git a/test/src/common/plugins/plugins-config.spec.js b/test/src/common/plugins/plugins-config.spec.js
@@ -0,0 +1,17 @@
+import {evaluatePluginsConfig} from '../../../../src/common/plugins/plugins-config';
+
+describe('evaluatePluginsConfig', function() {
+  const config = {
+    plugins: {
+      kava: {
+        myHandler: function() {}
+      }
+    }
+  };
+
+  it('should save the function after evaluatePluginsConfig called', function() {
+    evaluatePluginsConfig(config);
+    config.plugins.kava.myHandler.should.exist;
+    config.plugins.kava.myHandler.should.be.instanceof(Function);
+  });
+});