Skip to content

Commit

Permalink
fix(FEC-11089): bumper preroll doesn't play after ima preroll (#428)
Browse files Browse the repository at this point in the history
Issue: bumper preroll doesn't play after ima preroll with playAdsWithMSE.
Solution: playAdsWithMSE detach/attach also for pre-roll, attach/detach should take control only when the media loaded.
  • Loading branch information
Yuvalke authored Mar 16, 2021
1 parent 0a46048 commit cd7a287
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/kaltura-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,8 @@ class KalturaPlayer extends FakeEventTarget {
const {
payload: {ad}
} = event;
if (ad && ad.linear && ad.position === 1 && !ad.inStream) {
// source set only after media loaded
if (ad && ad.linear && ad.position === 1 && !ad.inStream && this.src) {
this._attachEventManager.listenOnce(this, AdEventType.AD_BREAK_START, () => this.detachMediaSource());
this._attachEventManager.listenOnce(this, AdEventType.AD_BREAK_END, () => this.attachMediaSource());
this._attachEventManager.listenOnce(this, AdEventType.AD_ERROR, () => this.attachMediaSource());
Expand Down

0 comments on commit cd7a287

Please sign in to comment.