Skip to content

Commit

Permalink
fix(FEC-9273): playing preroll on AV player (ios+playsinline=false) g…
Browse files Browse the repository at this point in the history
…ets the player stuck (#262)

config `disableMediaPreload:true` for ios + playsinline is false
  • Loading branch information
yairans authored Aug 1, 2019
1 parent 2ec29cc commit fb238b4
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions src/common/utils/setup-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ function getDefaultOptions(options: PartialKPOptionsObject): KPOptionsObject {
checkNativeTextTracksSupport(defaultOptions);
setDefaultAnalyticsPlugin(defaultOptions);
configureLGTVDefaultOptions(defaultOptions);
configureIMADefaultOptions(defaultOptions);
configureDAIDefaultOptions(defaultOptions);
configureBumperDefaultOptions(defaultOptions);
configureExternalStreamRedirect(defaultOptions);
Expand Down Expand Up @@ -379,6 +380,22 @@ function configureLGTVDefaultOptions(options: KPOptionsObject): void {
}
}

/**
* Sets default config option for ima plugin
* @private
* @param {KPOptionsObject} options - kaltura player options
* @returns {void}
*/
function configureIMADefaultOptions(options: KPOptionsObject): void {
if (isIos() && options.plugins && options.plugins.ima && !options.plugins.ima.disable) {
const playsinline = Utils.Object.getPropertyPath(options, 'playback.playsinline');
const disableMediaPreloadIma = Utils.Object.getPropertyPath(options, 'plugins.ima.disableMediaPreload');
if (playsinline === false && typeof disableMediaPreloadIma !== 'boolean') {
Utils.Object.createPropertyPath(options, 'plugins.ima.disableMediaPreload', true);
}
}
}

/**
* Sets default config option for dai plugin
* @private
Expand Down

0 comments on commit fb238b4

Please sign in to comment.