Skip to content

Commit

Permalink
fix(FEC-10455): incorrect order in reset and destroy process (#353)
Browse files Browse the repository at this point in the history
Issue: player.destroy() sending invalid 'stop' bookmark with position val 0
Solution: reorder the compenet destroy since some of them depend on playkit.

Solve: FEC-10455.
  • Loading branch information
Yuvalke authored Sep 2, 2020
1 parent bfaf3f7 commit fc9bf96
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/kaltura-player.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@ class KalturaPlayer extends FakeEventTarget {
this._reset = true;
this._firstPlay = true;
this._playbackStart = false;
this._localPlayer.reset();
this._uiWrapper.reset();
this._pluginManager.reset();
this._localPlayer.reset();
}
}

Expand All @@ -249,11 +249,11 @@ class KalturaPlayer extends FakeEventTarget {
this._reset = true;
this._firstPlay = true;
this._playbackStart = false;
this._localPlayer.destroy();
this._uiWrapper.destroy();
this._eventManager.destroy();
this._playlistManager.destroy();
this._pluginManager.destroy();
this._playlistManager.destroy();
this._localPlayer.destroy();
this._eventManager.destroy();
this._pluginsConfig = {};
const targetContainer = document.getElementById(targetId);
if (targetContainer && targetContainer.parentNode) {
Expand Down

0 comments on commit fc9bf96

Please sign in to comment.