Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add kaltura url params #11

Merged
merged 10 commits into from
Jul 30, 2017
Merged

feat: add kaltura url params #11

merged 10 commits into from
Jul 30, 2017

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 24, 2017

No description provided.

@yairans yairans requested review from OrenMe and dan-ziv July 24, 2017 15:25
@dan-ziv
Copy link
Contributor

dan-ziv commented Jul 24, 2017 •
edited
Loading

@yairans @OrenMe
Without any context to the implementation itself,
I think in general we need to keep the ES6-Flow convention also in this repo (we have not been so careful about it until now).
Which means to wrap any logic-related functions with es6 classes and use flow types.

In this PR context - maybe create KalturaParamsHandler class and use all those functions as a private members of the class which will expose only addKalturaParams api?

@yairans
Copy link
Contributor Author

yairans commented Jul 25, 2017

@dan-ziv
this is a util with main method addKalturaParams and some helpers. like other utils we have.
regarding flow, all function are flow typed.

@yairans yairans changed the title Kaltura params feat: add kaltura url params Jul 30, 2017
@yairans yairans merged commit 6f3a543 into develop Jul 30, 2017
@yairans yairans deleted the kaltura-params branch July 30, 2017 10:45
OrenMe pushed a commit that referenced this pull request Jul 30, 2017
@yairans @OrenMe
feat: add kaltura url params (#11)
1b36a12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @dan-ziv