Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8202): Session ID isn't sent when reporting analytics #118

Merged
merged 2 commits into from
May 9, 2018
Merged

fix(FEC-8202): Session ID isn't sent when reporting analytics #118

merged 2 commits into from
May 9, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented May 7, 2018

Description of the Changes

Change the new player config by reference and then configure it to the player.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this May 7, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans May 7, 2018 09:32
@OrenMe OrenMe merged commit 72c4b4e into master May 9, 2018
@dan-ziv dan-ziv deleted the FEC-8202 branch May 9, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe