Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8375): plugins data not evaluated #143

Merged
merged 3 commits into from
Jul 3, 2018
Merged

fix(FEC-8375): plugins data not evaluated #143

merged 3 commits into from
Jul 3, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Jul 3, 2018 •
edited by yairans
Loading

Description of the Changes

forgot to pass value param to evaluation method

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe
fix: plugins data not evaluated
1872848 
forgot to pass value param to evaluation method
@OrenMe OrenMe self-assigned this Jul 3, 2018
@OrenMe OrenMe requested a review from yairans July 3, 2018 15:40
@OrenMe OrenMe changed the title fix: plugins data not evaluated fix(FEC-8375): plugins data not evaluated Jul 3, 2018
@yairans yairans merged commit 0033e93 into master Jul 3, 2018
@yairans yairans deleted the fixParamEval branch July 3, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @yairans