Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8474): playback starts muted on change media - iOS #151

Merged
merged 3 commits into from
Aug 19, 2018
Merged

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Aug 14, 2018

Description of the Changes

Issue: The auto play testing video tag is created before any user gesture, hence in change media it returns that auto play is non valid although the main video tag can auto play.
Solution: Listen to the first UI_CLICKED event (once SOURCE_SELECTED event) and call to setCapabilities with autoPlay:true

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Aug 14, 2018
@yairans yairans changed the title fix(FEC-8474): Playback starts muted on change media - Ios fix(FEC-8474): Playback starts muted on change media - IOS Aug 14, 2018
@yairans yairans changed the title fix(FEC-8474): Playback starts muted on change media - IOS fix(FEC-8474): Playback starts muted on change media - iOS Aug 14, 2018
// Trigger to load the auto play testing video tag
getCapabilities();
};
player.addEventListener(player.Event.UI.UI_CLICKED, onUIClicked);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change assumes that by the first UI_CLICKED the main video tag is always can auto play.
But this assumption is wrong!!!.
Consider a case that the first entry request is failed, and the player is in an error state.
By click on the error overlay (for retry for example) we get UI_CLICKED but the main video tag is still cannot auto play, as it has never played.

@yairans yairans changed the title fix(FEC-8474): Playback starts muted on change media - iOS fix(FEC-8474): playback starts muted on change media - iOS Aug 16, 2018
@yairans yairans merged commit c5f332f into master Aug 19, 2018
@yairans yairans deleted the FEC-8474 branch August 19, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants