Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add new playkit path alias #157

Merged
merged 1 commit into from
Oct 7, 2018
Merged

fix: add new playkit path alias #157

merged 1 commit into from
Oct 7, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Oct 7, 2018 •
edited
Loading

Description of the Changes

adding alias for the new playkit package (per the new stracture)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Oct 7, 2018
@odedhutzler odedhutzler changed the title fix: fix path alias fix: fix playkit path alias Oct 7, 2018
@odedhutzler odedhutzler changed the title fix: fix playkit path alias fix: change playkit path alias Oct 7, 2018
@odedhutzler odedhutzler changed the title fix: change playkit path alias fix: add new playkit path alias Oct 7, 2018
@odedhutzler odedhutzler merged commit 5bfd1d1 into master Oct 7, 2018
@odedhutzler odedhutzler deleted the fix-playkit-alias-path branch October 7, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedhutzler @OrenMe