fix(FEC-8594): when casting via Play on TV button the Captions/Audio is not displayed #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
previously requested changes
Oct 25, 2018
src/common/cast/player-snapshot.js
Outdated
| * @returns {?string} - The audio language or undefined. | ||
| */ | ||
| function getAudioLanguage(player: KalturaPlayer): ?string { | ||
| if (player.currentTime > 0) { |
There was a problem hiding this comment.
why do you need if (player.currentTime > 0) { check? if player never started playing then getActiveTracks will return nothing and you can rely on that
OrenMe
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
If the player has started to play it will return the current played language.
Otherwise, it will return the configured language.
CheckLists