Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8153): save reference to player instances and expose API to get them #174

Merged
merged 8 commits into from
Nov 14, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 13, 2018

Description of the Changes

Save reference to each instantiated player.
Add methods to get all players or a player by ID.
Make sure to delete the reference upon destroying a player.

  • will add tests once review is done.
  • still deliberating if to add this code in its own module. doing so will add some boilerplate code of module management which i'm not sure is worth the addition, i.e. need to add register player and delete player methods....

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Nov 13, 2018
@OrenMe OrenMe changed the title feat(FEC-8153): save reference to player instances feat(FEC-8153): save reference to player instances and expose API to get them Nov 13, 2018
src/kaltura-player.js Outdated Show resolved Hide resolved
src/kaltura-player.js Outdated Show resolved Hide resolved
src/kaltura-player.js Outdated Show resolved Hide resolved
@OrenMe
Copy link
Contributor Author

OrenMe commented Nov 14, 2018

@dan-ziv please review CR changes

dan-ziv
dan-ziv previously approved these changes Nov 14, 2018
@OrenMe OrenMe merged commit 764849b into master Nov 14, 2018
@OrenMe OrenMe deleted the FEC-8153 branch November 14, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants