Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8705): playlist - OTT support #186

Merged
merged 19 commits into from
Dec 16, 2018
Merged

feat(FEC-8705): playlist - OTT support #186

merged 19 commits into from
Dec 16, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 10, 2018 •
edited
Loading

Description of the Changes

  • change loadPlaylistByEntryList api to get array of objects instead of strings (backward compatible)
  • load a playlist item using mediaInfo object instead of entryId string
  • update a playlist item poster using addKalturaPoster api
  • update item sources using dedicated api instead of mergeDeep which causes side effects (e.g poster overriding)

Depends on kaltura/playkit-js-providers#73

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Dec 10, 2018
@yairans yairans requested a review from a team December 10, 2018 10:09
@yairans yairans changed the title Fec 8705 @yairans feat(FEC-8705): playlist - OTT support Dec 10, 2018
@yairans yairans changed the title @yairans feat(FEC-8705): playlist - OTT support feat(FEC-8705): playlist - OTT support Dec 10, 2018
@yairans yairans merged commit 6db068b into master Dec 16, 2018
@yairans yairans deleted the FEC-8705 branch December 16, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe