feat(kaltura player): export setup method #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
OrenMe
suggested changes
Jun 26, 2017
src/create.js
Outdated
| let provider = new OvpProvider(config.partnerId); | ||
| return provider.getConfig(config.entryID) | ||
| .then(data => { | ||
| player.configure(data); |
There was a problem hiding this comment.
We currently don't pass the config data we pass to create method to the playkit.configure, which can contain player config as well as config to the provider.
Need to handle the entire config object that we defined for playkit
dan-ziv
reviewed
Jun 26, 2017
src/index.js
Outdated
| // TODO: Import plugins | ||
|
|
||
| export {Playkit, OvpProvider, PlaykitUI}; | ||
| export {Playkit, OvpProvider, PlaykitUI, create}; |
yairans
changed the title
OrenMe
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.