Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8842): playlist - item sources config ignored #211

Merged
merged 5 commits into from
Jan 20, 2019
Merged

fix(FEC-8842): playlist - item sources config ignored #211

merged 5 commits into from
Jan 20, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 17, 2019 •
edited
Loading

Description of the Changes

  • config the player with the item sources config before loadMedia
  • delete empty url properties (hls\dash\progressive) from item sources config, otherwise the empty url property will override the provider's url property

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jan 17, 2019
@yairans yairans requested a review from a team January 17, 2019 15:12
@yairans yairans merged commit fc73982 into master Jan 20, 2019
@yairans yairans deleted the FEC-8842 branch January 20, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yairans