Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8631): bumper plugin #224

Merged
merged 16 commits into from
Jun 13, 2019
Merged

feat(FEC-8631): bumper plugin #224

merged 16 commits into from
Jun 13, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 28, 2019 •
edited
Loading

Description of the Changes

Set inBrowserFullscreenForIOS :true by default

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team February 28, 2019 13:55
@yairans yairans self-assigned this Feb 28, 2019
@yairans yairans mentioned this pull request Feb 28, 2019
Merged
@yairans yairans merged commit 627dc15 into master Jun 13, 2019
@yairans yairans deleted the FEC-8631 branch June 13, 2019 14:06
yairans added a commit to kaltura/playkit-js-bumper that referenced this pull request Jun 13, 2019
@yairans
feat(FEC-8631): bumper plugin (#1)
a80b298 
Dependes on
* kaltura/kaltura-player-js#224
* kaltura/playkit-js#350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe