Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inBrowserFullscreen path #248

Merged
merged 3 commits into from
Jun 20, 2019
Merged

fix: inBrowserFullscreen path #248

merged 3 commits into from
Jun 20, 2019

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 20, 2019 •
edited
Loading

Description of the Changes

set playback.inBrowserFullscreen instead of ui.components.fullscreen.inBrowserFullscreenForIOS

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team June 20, 2019 12:00
@yairans yairans self-assigned this Jun 20, 2019
OrenMe
OrenMe previously approved these changes Jun 20, 2019
View reviewed changes
@yairans yairans merged commit 75054ea into master Jun 20, 2019
@yairans yairans deleted the fix-full-screen-path branch June 20, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe