Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useNativeTextTrack doesn't change to true by default on MacOS #258

Merged
merged 2 commits into from
Jul 28, 2019
Merged

fix: useNativeTextTrack doesn't change to true by default on MacOS #258

merged 2 commits into from
Jul 28, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jul 23, 2019 •
edited
Loading

Description of the Changes

fix check for MacOS

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke Yuvalke requested a review from OrenMe July 23, 2019 15:12
@Yuvalke Yuvalke self-assigned this Jul 23, 2019
@Yuvalke Yuvalke changed the title fix mac os config problem fix: useNativeTextTrack doesn't change to true by default on MacOS Jul 23, 2019
OrenMe
OrenMe previously approved these changes Jul 24, 2019
View reviewed changes
@Yuvalke Yuvalke merged commit f4ee047 into master Jul 28, 2019
@Yuvalke Yuvalke deleted the mac-config-native-track branch July 28, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe