Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9326): report product version #275

Merged
merged 2 commits into from
Oct 31, 2019
Merged

feat(FEC-9326): report product version #275

merged 2 commits into from
Oct 31, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Oct 31, 2019

Description of the Changes

get Product version from uiConf.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
feat(FEC-9326): report productVersion
36deb9b 
get Product version from uiConf.
@Yuvalke Yuvalke requested a review from a team October 31, 2019 10:24
@Yuvalke Yuvalke self-assigned this Oct 31, 2019
@Yuvalke Yuvalke requested review from OrenMe, yairans and RoyBregman and removed request for a team October 31, 2019 11:20
@OrenMe OrenMe merged commit 304f9ca into master Oct 31, 2019
@OrenMe OrenMe deleted the FEC-9326 branch October 31, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe