Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-9465): internationalization (i18n) - player localization #304

Merged
merged 2 commits into from
Feb 16, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 13, 2020

Description of the Changes

Copy the translations directory from playkit-js-ui (kaltura/playkit-js-ui#485) to the dist folder

Solves FEC-9465

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe previously approved these changes Feb 16, 2020
yairans added a commit to kaltura/playkit-js-ui that referenced this pull request Feb 16, 2020
* Move `translations` folder to the root to be available to kaltura-player (kaltura/kaltura-player-js#304)
* Add French translation 

Solves FEC-9465
@yairans yairans merged commit 6b33757 into master Feb 16, 2020
@yairans yairans deleted the FEC-9465 branch February 16, 2020 10:42
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
* Move `translations` folder to the root to be available to kaltura-player (kaltura/kaltura-player-js#304)
* Add French translation 

Solves FEC-9465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants