Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-9631): add support for out of band text tracks on cast sdk #319

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 1, 2020

Description of the Changes

Update the local player on cast disconnection with the captions from the cast snapshot

Solves FEC-9631

Related to kaltura/playkit-js-cast-sender#32

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

yairans added a commit to kaltura/playkit-js-cast-sender that referenced this pull request Jun 1, 2020
)

* Use [`media.tracks`](https://developers.google.com/cast/docs/reference/chrome/chrome.cast.media.MediaInfo#tracks) to pass the configured captions to the receiver 
* Ignore out-of-band caption if it already exists as in-band
* Fix 'Off' track id that can be duplicated

Solves FEC-9631

Related to kaltura/kaltura-player-js#319
@yairans yairans merged commit 16562b6 into master Jun 1, 2020
@yairans yairans deleted the FEC-9631 branch June 1, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants