Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: old browser(IE11) get method in proxy doesn't work #345

Merged
merged 1 commit into from
Aug 5, 2020
Merged

fix: old browser(IE11) get method in proxy doesn't work #345

merged 1 commit into from
Aug 5, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Aug 4, 2020

Description of the Changes

issue: proxy applied when ui is disable
solution: add loose mode for the class to enable get in the proxy.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: old browser(IE11) get mehtod in proxy doesn't work
56905e7 
issue: proxy applied when ui is disable
solution: add loose mode for class to enable get in proxy.
@Yuvalke Yuvalke requested review from OrenMe and dan-ziv August 4, 2020 15:10
@Yuvalke Yuvalke self-assigned this Aug 4, 2020
@Yuvalke Yuvalke merged commit 4d3f69c into master Aug 5, 2020
@Yuvalke Yuvalke deleted the fix-ie11 branch August 5, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe