Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10404): media doesn't work properly on Safari browser - no video displayed - Regression bug #347

Merged
merged 4 commits into from
Aug 9, 2020
Merged

fix(FEC-10404): media doesn't work properly on Safari browser - no video displayed - Regression bug #347

merged 4 commits into from
Aug 9, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Aug 9, 2020 •
edited
Loading

Description of the Changes

Exposing crossOrigin getter and setter

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Yuvalke
Yuvalke previously approved these changes Aug 9, 2020
View reviewed changes
@RoyBregman RoyBregman merged commit 7456bee into master Aug 9, 2020
@RoyBregman RoyBregman deleted the FEC-10404-VR branch August 9, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@Yuvalke Yuvalke Yuvalke approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyBregman @OrenMe @Yuvalke