Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10417): playlist by sources stuck after press Play button when set IMA or bumper plugins #349

Merged
merged 6 commits into from
Aug 20, 2020

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Aug 13, 2020

Description of the Changes

When playlist configured with sources the play flow start from the configure of the playlist manager.
In that point, no listener and handlers attached on the player, so nothing happens when playlist item is set.
The solution is the bind all the listeners first, and then configure the playlist manager.

Solves FEC-10417

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from a team August 13, 2020 09:55
@dan-ziv dan-ziv self-assigned this Aug 13, 2020
OrenMe
OrenMe previously approved these changes Aug 13, 2020
@OrenMe
Copy link
Contributor

OrenMe commented Aug 13, 2020

@yairans please check why we didn't see this in tests(do we have for this kind of thing?)

@yairans
Copy link
Contributor

yairans commented Aug 13, 2020

@dan-ziv please add a unit test as discussed

@yairans yairans merged commit b2256f3 into master Aug 20, 2020
@yairans yairans deleted the FEC-10417 branch August 20, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants