Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10161): add kava analytics url from server response #355

Merged
merged 7 commits into from
Sep 2, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 2, 2020

Description of the Changes

Issue: kava reports to production env instead QA
Solution: server response had an analytics URL, by default from the platform it'll be taken from there.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Issue: kava reports to producation env instead qa
Solution: server response had analyitcs url so we'll take it from there.
@Yuvalke Yuvalke requested a review from a team September 2, 2020 11:34
@Yuvalke Yuvalke self-assigned this Sep 2, 2020
dan-ziv
dan-ziv previously approved these changes Sep 2, 2020
OrenMe
OrenMe previously approved these changes Sep 2, 2020
OrenMe
OrenMe previously approved these changes Sep 2, 2020
@Yuvalke Yuvalke merged commit e4ce3f1 into master Sep 2, 2020
@Yuvalke Yuvalke deleted the FEC-10161 branch September 2, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants