Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10524): get logger from playkit and set to ui and provider #360

Merged
merged 6 commits into from
Oct 5, 2020
Merged

fix(FEC-10524): get logger from playkit and set to ui and provider #360

merged 6 commits into from
Oct 5, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 29, 2020

Description of the Changes

Issue: we bundling a few js-logger on Kaltura player.
Solution: get logger from playkit and set it to UI and provider.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Yuvalke and others added 2 commits September 27, 2020 11:51
@Yuvalke
fix: get logger from playkit.
24bd811 
Issue: logger exist twice on kaltura player and playkit.
Solution: take the logger from playkit.
align all logger to static.
@Yuvalke
pass logger to ui and provider
e7334d7
@Yuvalke Yuvalke requested a review from a team September 29, 2020 10:22
@Yuvalke Yuvalke self-assigned this Sep 29, 2020
@Yuvalke Yuvalke changed the title fix: get logger from playkit and set to ui and provider fix(FEC-10524): get logger from playkit and set to ui and provider Sep 30, 2020
@Yuvalke Yuvalke merged commit 7387569 into master Oct 5, 2020
@Yuvalke Yuvalke deleted the perfomece-issue branch October 5, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Yuvalke