Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10632): handle player dimensions dynamically #373

Merged
merged 9 commits into from
Nov 23, 2020
Merged

feat(FEC-10632): handle player dimensions dynamically #373

merged 9 commits into from
Nov 23, 2020

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 15, 2020 •
edited by OrenMe
Loading

Description of the Changes

Add setter to the dimensions field.

Resolves: FEC-10632

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from a team November 15, 2020 13:00
@dan-ziv dan-ziv self-assigned this Nov 15, 2020
@dan-ziv dan-ziv changed the title feat(FEC-10632): Handle Player Dimensions Dynamically feat(FEC-10632): handle player dimensions dynamically Nov 17, 2020
OrenMe
OrenMe previously approved these changes Nov 22, 2020
View reviewed changes
@dan-ziv dan-ziv merged commit c0bf2e1 into master Nov 23, 2020
@dan-ziv dan-ziv deleted the FEC-10632 branch November 23, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe