Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-10749): playlist by sources stuck #386

Merged
merged 4 commits into from
Dec 6, 2020
Merged

fix(FEC-10749): playlist by sources stuck #386

merged 4 commits into from
Dec 6, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Dec 3, 2020

Description of the Changes

Issue: #370 moved the redirect default settings from setup to loadMedia
so sources could be undefined in kaltura-player constructor
Solution: pass empty object to sources to the local player if it's undefined

Solves FEC-10749

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team December 3, 2020 15:59
@yairans yairans self-assigned this Dec 3, 2020
OrenMe
OrenMe previously approved these changes Dec 3, 2020
@OrenMe
Copy link
Contributor

OrenMe commented Dec 3, 2020

@yairans can we add test for this? if no sources on constructor don't call configure

@yairans yairans merged commit a747f70 into master Dec 6, 2020
@yairans yairans deleted the FEC-10749 branch December 6, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants