feat(FEC-10766): create text config section and option for styling #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: text track doesn't have a config for styling, there is only an API for styling. Solution: create a text container for the text track and add the options for styling the text track.
RoyBregman
reviewed
Dec 27, 2020
| playback: { | ||
| enableCEA708Captions: true, |
There was a problem hiding this comment.
Maybe leave this test to check backward compatibility and add a comment to mention that?
There was a problem hiding this comment.
Oh, but its one config for all tests... Nevermind
OrenMe
previously approved these changes
Dec 27, 2020
OrenMe
approved these changes
Dec 28, 2020
OrenMe
suggested changes
Dec 28, 2020
src/kaltura-player.js
Outdated
| @@ -434,6 +434,10 @@ class KalturaPlayer extends FakeEventTarget { | |||
| return this._localPlayer.textStyle; | |||
| } | |||
|
|
|||
| get textDisplaySetting(): Object { | |||
OrenMe
previously approved these changes
Dec 29, 2020
OrenMe
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue: text track doesn't have a config for styling, there is only an API for styling.
Solution: create a text container for the text track and add the options for styling the text track.
CheckLists