Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10687): Allow partial config in setMedia API #394

Merged
merged 13 commits into from
Jan 24, 2021
Merged

fix(FEC-10687): Allow partial config in setMedia API #394

merged 13 commits into from
Jan 24, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Dec 23, 2020

Description of the Changes

When using setMedia API, if plugins object isn't set the player is crashing.
Create the plugins object internal if isn't exists.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Dec 23, 2020
OrenMe
OrenMe previously approved these changes Dec 27, 2020
View reviewed changes
@dan-ziv dan-ziv requested a review from OrenMe January 12, 2021 07:45
@OrenMe
Update src/common/utils/thumbs.js
90d7371 
Co-authored-by: Oren Me <oren.me@gmail.com>
@dan-ziv dan-ziv requested a review from OrenMe January 19, 2021 11:36
OrenMe
OrenMe reviewed Jan 19, 2021
View reviewed changes
src/common/utils/thumbs.js Outdated Show resolved Hide resolved
@dan-ziv dan-ziv requested a review from OrenMe January 24, 2021 09:10
OrenMe
OrenMe previously approved these changes Jan 24, 2021
View reviewed changes
@dan-ziv dan-ziv merged commit aab1eab into master Jan 24, 2021
@dan-ziv dan-ziv deleted the FEC-10687 branch January 24, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@yairans yairans Awaiting requested review from yairans

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe